Skip to content

logging-6.6: Switch vector to 0.54.0 branch#10574

Open
xperimental wants to merge 3 commits into
openshift-eng:logging-6.6from
xperimental:logging-6.6-vector
Open

logging-6.6: Switch vector to 0.54.0 branch#10574
xperimental wants to merge 3 commits into
openshift-eng:logging-6.6from
xperimental:logging-6.6-vector

Conversation

@xperimental
Copy link
Copy Markdown

@xperimental xperimental commented May 13, 2026 •
edited
Loading

This switches 6.6 to a newer vector version. The rust version is the latest currently available in UBI9 and is hopefully sufficient for building vector.

The llvm version was taken from a local test build.

This requires these upstream changes:

/label tide/merge-method-squash
/hold waiting for upstream changes

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels May 13, 2026
@rayfordj
Copy link
Copy Markdown
Contributor

rayfordj commented May 13, 2026 •
edited
Loading

@xperimental , open test build ❌

logging-6-6-vector-5h88j-build-images-0/logs#L1168-L1171

Ignore this build; too many things in-flight and I failed to run it against your open "depend-on" PR linked above. 🤦

rayfordj
rayfordj approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 It amuses me to see the bot suggested as a reviewer 😆

I don't see anything immediately concerning with these changes worth deferring review/approval.

/lgtm
/approve

Before removing hold, if you would like test builds once the 'depends-on' upstream PR merges, please reach out to ART in Slack with the request.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayfordj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@rayfordj
Copy link
Copy Markdown
Contributor

rayfordj commented May 14, 2026

❌ open test build

  • ❌ s390x
  • ❌ ppc64le
  • ✔️ x86_64
  • ❌ aarch64

❌ open test build

  • ❌ s390x
  • ❌ ppc64le
  • ✔️ x86_64
  • ❌ aarch64

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2026
@xperimental
Copy link
Copy Markdown
Author

xperimental commented May 18, 2026 •
edited
Loading

  • Updated with an additional package that was added to the build last week
  • The non-x64 builds seem to fail because the non-x64 binaries of protoc seem to be broken. This is being investigated -> keeping hold
  • I'll post another comment when I need another test build with fixed non-x64 protoc 🙂

@rayfordj
Copy link
Copy Markdown
Contributor

rayfordj commented May 18, 2026

/lgtm

re: test builds -- I tend to occasionally lose PRs/comments in deluge of notifications, so if it seems "too long", please raise a thread in forum-ocp-art. 😎

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2026
@xperimental xperimental force-pushed the logging-6.6-vector branch from 9cc8efd to 194cafb Compare May 20, 2026 09:34
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

New changes are detected. LGTM label has been removed.

@xperimental
Copy link
Copy Markdown
Author

xperimental commented May 20, 2026

@rayfordj I have updated the PR with new packages (we now pull the protobuf compiler from RPMs instead of having it in the repository). Can you run another test build? Thanks 🙂

@rayfordj
Copy link
Copy Markdown
Contributor

rayfordj commented May 20, 2026

❌ open test build

@xperimental
Copy link
Copy Markdown
Author

xperimental commented May 21, 2026

Thanks for the test build, trying to figure out the solution ...

Do you perhaps know what other products do to get a protobuf compiler?

As a possible alternative: The upstream is using a script to pull a specific version of the compiler from github ... while we do not have network during the build ... would it maybe be possible to "preload" the binaries and then pull them from some sort of local cache during the build? (with the complication that this would be a different one per architecture)

@rayfordj
Copy link
Copy Markdown
Contributor

rayfordj commented May 21, 2026

Do you perhaps know what other products do to get a protobuf compiler?

I'm not aware of any off-hand and chai-bot had this to say:

🤖 : protobuf-compiler is not currently used by any ART-built image, but this PR would introduce it as a build dependency for the vector image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rayfordj rayfordj rayfordj approved these changes

Assignees

@rayfordj rayfordj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xperimental @rayfordj